Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

displayName #67

Closed
jamiebuilds opened this issue Dec 24, 2015 · 3 comments
Closed

displayName #67

jamiebuilds opened this issue Dec 24, 2015 · 3 comments
Labels
james-is-awesome

Comments

@jamiebuilds
Copy link
Collaborator

Alright, this has been a common issue so I'm folding every other issue into this one single one.

Basically since in Babel 6 plugin visitors get merged, this plugin will always run before babel-plugin-transform-react-display-name, meaning that displayName will never get added because we've already changed the AST.

The fix here has to be inside of the displayName plugin so that it is forced to run before any other transforms.

I'm locking this issue because I don't want any unnecessary noise, I've already identified the problem.
Repository owner locked and limited conversation to collaborators Dec 24, 2015
@jamiebuilds
Copy link
Collaborator Author

babel/babel#3216

@gaearon
Copy link
Owner

gaearon commented Dec 27, 2015

Good. So we can close this after next Babel release?

@jamiebuilds
Copy link
Collaborator Author

Yeah

@gaearon gaearon closed this as completed Mar 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
james-is-awesome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force displayName plugin to run before all other transforms babel/babel
2 participants
@gaearon @jamiebuilds