Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not respect public field binding #554

Closed
gajus opened this issue Apr 28, 2017 · 2 comments
Closed

does not respect public field binding #554

gajus opened this issue Apr 28, 2017 · 2 comments
Labels

Comments

@gajus
Copy link

gajus commented Apr 28, 2017

Description

What you are reporting:

  • A bug

Expected behavior

What you think should happen:

handleClose should be called with the current context of the component.

Actual behavior

What actually happens:

handleClose is called with the old context of the container.

Environment

React Hot Loader version:

^3.0.0-beta.6

Run these commands in the project folder and fill in their results:

  1. node -v: v7.9.0
  2. npm -v: v4.2.0

Then, specify:

  1. Operating system: OS
  2. Browser and version: Chrome v58

Reproducible Demo

git clone git@github.com:gajus/sanity-test.git
cd ./sanity-test
npm run install
npm run dev

Click "Click me" button.

Expected result: movie prop is not null.
Curent result movie prop is null.

Additional information

The lack of context binding is visible in the code transpilation difference without/ with react-hot-loader/babel https://gist.github.com/gajus/2d0867f326d5c69702f057c7cd7cf15f/revisions

@gajus gajus changed the title does not respect public field bindin does not respect public field binding Apr 28, 2017
@gajus
Copy link
Author

gajus commented Apr 28, 2017

The real issue is documented here. gaearon/react-proxy#69

@gregberge
Copy link
Collaborator

I have tested it with React Hot Loader v4 and it is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants