Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider forcing remount with some heuristics #15

Open
gaearon opened this issue Aug 23, 2015 · 4 comments
Open

Consider forcing remount with some heuristics #15

gaearon opened this issue Aug 23, 2015 · 4 comments

Comments

@gaearon
Copy link
Owner

gaearon commented Aug 23, 2015

If constructor, componentWillMount, or componentDidMount code changed, we should probably force remounting. We can use toString() to check (it won't work for classic components though, as their method implementations are inside React itself so that they work with mixins).

@Yomguithereal
Copy link
Contributor

This would be a very comfortable feature indeed. Can I help you with this somehow @gaearon?

@gaearon
Copy link
Owner Author

gaearon commented Oct 20, 2015

Yeah, feel free to experiment. You'd need to modify the code to create a new proxy class and prototype under some conditions and return them from get() after “incompatible” update().

@yonatanmn
Copy link

any update here? @Yomguithereal

@creeperyang
Copy link

Related to #39. Better to consider things Comprehensively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants