-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with React 16.3 forwardRef #82
Comments
@haggholm any progress on this issue? |
Unfortunately I haven’t had time to return to it yet. |
I have also been getting this issue when using a HOC that includes |
+1 same issue. |
I've added some updated information and a short-term fix to facebook/metro#272 |
Similar issue with debugging results. |
Please excuse a somewhat vague report as I’m just investigating a rather involved build system.
Our codebase has (a) a custom component base class, which is generally discouraged; and (b) HOCs that use the new
forwardRef()
functionality. This lead to a very strange breakage when I tried to migrate some components that currently use our internalBaseComponent
to instead extendReact.Component
(orPureComponent
) directly: our React Native app crashed in react-proxy’s update() function with the error'Expected a constructor.'
. It appears that when extending the React classes, the component ends up being not a class, but instead an object with the shape (per Chrome debugger)It’s not clear to me why this does not happen with our custom base class: I suppose
forwardRef()
treats it differently, being a full-blown ES6 class as opposed to what React provides. It’s also not clear to me exactly where I should be filing this bug:react-proxy
,react-transform-hmr
,metro
, …? Any thoughts welcomed.The text was updated successfully, but these errors were encountered: