Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wait_for_completion in download_datasets from the bioblend call. #24

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Conversation

andreyto
Copy link

@andreyto andreyto commented Apr 9, 2019

This fixes error from current bioblend dependency, where this argument has been removed. The argument is still accepted by the parsec script for compatibility, but it is ignored.
This was tested in this tutorial.

@hexylena
Copy link
Member

Thanks for the fix @andreyto, I'll start pinning the bioblend version so we don't have this problem in the future.

@hexylena hexylena merged commit 3e56cf3 into galaxy-iuc:master Apr 10, 2019
@hexylena
Copy link
Member

Hi @andreyto, ok, made a new release with pinned bioblend. Parsec is nearly completely automatically generated, so the automatic updating has removed your compatibility flag.

This is a tradeoff I feel comfortable making, as I don't want to extend our auto-generation tool to support this.

It's on pypi now as 1.12.0 :)

@andreyto
Copy link
Author

@erasche, yes, this is even better. Thanks a lot! I the absence of R client bindings, parsec is the easiest way for the R users to access Galaxy remotely unless they want to code RESTful calls directly with httr. Great tool.

@andreyto andreyto deleted the at_fixes branch April 10, 2019 13:27
@hexylena
Copy link
Member

@andreyto great, I'm glad to hear it's useful in that case! I'll be sure to add it to the RStudio Galaxy IE while I'm at it.

For the use case in your tutorial, we also have:

Where if your user has GALAXY_URL and API_KEY set, they should just be able to run gx_get(<id>) in their R session and it will return a path. Those two repositories probably have some hardcoded values which need to be fixed for general usage, but maybe it is interesting for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants