Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reference_id / source_id vs folder / file name consistency check #54

Open
cdeil opened this issue Dec 14, 2016 · 2 comments
Open
Assignees

Comments

@cdeil
Copy link
Contributor

cdeil commented Dec 14, 2016

I just noticed that we had SED input/papers/2007/2007A%26A...472..489A/tev-000115.ecsv in the input folder, but it wasn't present in the output folder:

$ find . -name '*000115*'
./input/papers/2007/2007A%26A...472..489A/tev-000115.ecsv
./input/papers/2007/2007A%26A...472..489A/tev-000115.yaml
./input/sources/tev-000115.yaml

The reason was that source_id in the input file was incorrect.
Fixed in 201c198 .

This is a reminder issue for myself that I should implement a consistency check for the input header keys reference_id and source_id versus the folder and file names.

@cdeil cdeil self-assigned this Dec 14, 2016
@cdeil
Copy link
Contributor Author

cdeil commented Dec 14, 2016

I've removed docs/data/sources/000132/gammacat_000132_2007A%26A...472..489A_sed.ecsv, which was an SED file put for the wrong source 132 as a result of the data entry error mentioned above in 4e5352e .

@pdeiml
Copy link
Collaborator

pdeiml commented Aug 18, 2017

I think this issue is the same or nearly the same as issue #126, isn't it?

@cdeil cdeil mentioned this issue Jan 25, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants