Review Goals

[GernotMaier]

The goal of the review is to obtain feedback on:

• overall concept and project structure
• coding standards and quality
• development and testing approach
• commonalities with other DPPS pipelines (which could be part of a possible DPPS core library)

This should not be an in depth review, but more to comment on the concept and ensure that this is good groundwork for future developments. We not expect you to spend more than 0.5-1 days on this.

gammmasim-tools is a collection of modules and applications, and does not include workflows or pipelines (yet). Note that there will be applications implemented in future, which will make use of tools provided by e.g., ctapipe (e.g., the muon analysis).

Suggestion for the review:

1. browse through the documentation.
2. browse through parts of the code.
3. (optional) try some example applications using the docker container with gammasim-tools, CORSIKA, sim_telarray installed (e.g., submit_data_from_external.py, derive_mirror_rnda.py).

Known issues

We are aware of a number of issues to be addressed in future:

• coverage is quite low at the moment, it will be resolved in the next "maintenance campaign".
• installation procedure needs improvement with correct implementation of setuptools (or whatever the preferred installation procedures for CTA tools will be)
• ...