Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simtool configuration requires a significant review and update #1055

Open
GernotMaier opened this issue Jul 11, 2024 · 1 comment
Open

simtool configuration requires a significant review and update #1055

GernotMaier opened this issue Jul 11, 2024 · 1 comment

Comments

@GernotMaier
Copy link
Contributor

All simtools print the tool configuration when giving the --help parameter. It is evident that

  1. a lot of the printed parameters are except for edge cases not relevant for most users
  2. some of the printed / configurable parameters are not relevant at all / should not be changed

This requires a review and improvement of the configuration classes to allow for a more fine-grained selection of the command line configuration.

We might consider as well a two-step help:

  • --help prints the most important parameters
  • --full_help (need a better name) prints all
@GernotMaier
Copy link
Contributor Author

Adding to this issue the inconsistent handling of command line parameters with units:

  1. -zenith 20 (implicitly expecting that this is in degrees)
  2. `-zenith "20 deg" (enforcing units; read in as string and convert to astropy quantity)
  3. -zenith "20. * u.deg" (adding a type=parse_quantity,` to argparser and read it in directly as astropy quantity)

We should handle this consistently among all tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant