Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'reasonable_range' field to schema files #1189

Open
GernotMaier opened this issue Oct 8, 2024 · 2 comments
Open

Add 'reasonable_range' field to schema files #1189

GernotMaier opened this issue Oct 8, 2024 · 2 comments

Comments

@GernotMaier
Copy link
Contributor

Model parameter schema currently include an allowed_range for values, e.g. for num_gains it is:

allowed_range:
      min: 1
      max: 2

We discussed to adding another field called reasonable_range (is this a good name?) to indicate the range of parameter values reasonable for CTA.

(and above example is not a good example for this!)

@orelgueta
Copy link
Contributor

Agree that this is needed. Just want to add that a value which is outside the reasonable_range should raise a warning and not an error.

@GernotMaier
Copy link
Contributor Author

This is easy to implement. Which parameters are good examples to add this?

Anyone with good examples from the model parameters? (altitude.schema.yml is probably reasonable in a range of 0-8000m.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants