Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml and pylint, flake8 #685

Closed
GernotMaier opened this issue Nov 20, 2023 · 1 comment · Fixed by #684 or #688
Closed

pyproject.toml and pylint, flake8 #685

GernotMaier opened this issue Nov 20, 2023 · 1 comment · Fixed by #684 or #688
Assignees

Comments

@GernotMaier
Copy link
Contributor

Noticed two issues related to linters:

Pylint:

  • configuration is listed explicit with every parameter in pyproject.toml (generated with --generate-toml-config). These are over 500 lines, makes it hard to navigate, and difficult to find which parameters we changed. Suggest to only list the settings we change (will maybe in 20 lines), see PR Linter updates #684
  • was there a reason not to use pylint as a action workflow? It is very pedantic and maybe it simply went on our nerves

Flake8

flake 8 configurations can be found in two places:

  • pre-commit is running with args: ["--max-line-length=100", "--extend-ignore=E203,E712"]
  • github action is running with ``--max-line-length 100 --per-file-ignores="_version.py:F401 E501" .`
This was linked to pull requests Nov 20, 2023
@GernotMaier
Copy link
Contributor Author

On the flake 8 warnings / errors ignores.

In .pre-commit - why do we ignore those two? I suggest to remove them, see PR #688

In CI-unittests:

Here we actually ignore only for version.py some warnings, so we should keep this.

@GernotMaier GernotMaier self-assigned this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant