Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-react-helmet): add support for base tag #16325

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

Nighthawk14
Copy link
Contributor

@Nighthawk14 Nighthawk14 commented Aug 2, 2019

Description

This supports the base tag as a child of Helmet

Examples

<Helmet>
  <base href="{{BASE_HREF}}" />
</Helmet>

@Nighthawk14 Nighthawk14 requested a review from a team as a code owner August 2, 2019 09:13
@wardpeet wardpeet changed the title Support base tag in gatsby-plugin-react-helmet feat(gatsby-plugin-react-helmet): add support fort base tag Aug 2, 2019
@Nighthawk14 Nighthawk14 changed the title feat(gatsby-plugin-react-helmet): add support fort base tag feat(gatsby-plugin-react-helmet): add support for base tag Aug 2, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. Looks good to me.

@wardpeet wardpeet merged commit 7325346 into gatsbyjs:master Aug 2, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 2, 2019

Holy buckets, @Nighthawk14 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@Nighthawk14 Nighthawk14 deleted the feat/support-base-tag branch August 2, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants