-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native loading="lazy" lacks dimensions inside gatsby-image. #17506
Comments
I think the problem here is that fluid images by their nature can't have their size set in the HTML, because they're supposed to resize to fit their container. I'm not sure if there's a way around this (or if it's actually a problem). |
I've created an upstream issue on chromium https://bugs.chromium.org/p/chromium/issues/detail?id=1002455. Seems like chrome doens't detect fluid containers and mark images without dimensions as faulty. You shouldn't worry about it. |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing! Thanks for being a part of the Gatsby community! 💪💜 |
Hey again! It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing! Thanks again for being part of the Gatsby community! |
👀 |
This issue is still relevant and should be reopened I think |
Still an issue. Even with it being fluid we should be able to pass in attributes |
This causes chrome not to lazy load at all, and the lighthouse/audit rankings are down the drain because of this. |
I'd also like to see this being addressed. Adding attributes to images, even when fluid, is slowly becoming a new best practice. |
We can’t use fluid images for now. I’m using only fixed images without the possibility to set attributes on fluid images... |
I am facing this issue as well, would be great if this could be adressed any time soon. |
Still facing this issue |
Still a thing |
Still an issue 😿 |
Still an issue here too (blazy in css backgrounds). |
Looks like the removal of this console warning was just merged into Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/2159142. Not sure when it will appear in Chrome, perhaps after the next major release (mid-May I believe)? |
As of 1st June using the latest release build of Chrome (Version 83.0.4103.61) this is still an issue. |
Still no changes about this issue. |
checking back, still seeing this issue. |
Still an issue |
Still an issue
|
Still an Issue as of today! |
I've just updated Chrome to Version 84.0.4147.89 (Official Build) (64 bit) and I'm not getting the console warning anymore, I suppose that the removal of the warning message was merged into Chrome stable 🎉 |
Closing as this was a Chrome issue that has apparently been resolved as per @E-PL! |
Description
I am using the fluid queries within gatsby-image. When using the default
loading="lazy"
, I get the following warning inside the console:I tried to search for this issue, but only found 2 unanswered questions on spectrum. I am using gatsby 2.15.11 and gatsby-image 2.2.17. As far as I can see the native lazy-loading has been introduced in gatsby-image 2.1.0.
It also appears on https://using-gatsby-image.gatsbyjs.org/
The text was updated successfully, but these errors were encountered: