Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print warning when resolvers take too long #23098

Closed
KyleAMathews opened this issue Apr 14, 2020 · 2 comments
Closed

print warning when resolvers take too long #23098

KyleAMathews opened this issue Apr 14, 2020 · 2 comments
Labels
help wanted Issue with a clear description that the community can help with. topic: GraphQL Related to Gatsby's GraphQL layer

Comments

@KyleAMathews
Copy link
Contributor

Custom graphql resolvers can hang indefinitely.

This is hard to discover and debug. We should print a warning when resolvers take too long to return. We tried setting a maxTimeout in #23095 but this broke some sites as @pvdz said:

for reference; this will block builds because the time isn't properly measured so if the first query gets delayed by another blocking process (webpack?) it'll measure a timeout for the first query and then abort the build
@KyleAMathews KyleAMathews added help wanted Issue with a clear description that the community can help with. topic: GraphQL Related to Gatsby's GraphQL layer labels Apr 14, 2020
@vladar
Copy link
Contributor

vladar commented Apr 14, 2020

Related: #21825

@freiksenet
Copy link
Contributor

Closing as duplicate of #21825.

@AlexRAV AlexRAV mentioned this issue Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issue with a clear description that the community can help with. topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KyleAMathews @vladar @freiksenet