Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Use enum for handling bid sorting #76

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Chore: Use enum for handling bid sorting #76

wants to merge 1 commit into from
+17 −8

Conversation

0ex-d
Copy link
Contributor

@0ex-d 0ex-d commented Jan 11, 2025

Used BidsOrderBy enum Option<BidsOrderBy> in place of Option<i8>.
Please follow this issue regarding my suggestion.

Bonus:

While running tests, noticed #[ignore = "TODO: to fix"], could someone please clarify on this?

helix/crates/database/src/postgres/postgres_db_service_tests.rs

Lines 590 to 592 in f26f257

#[tokio::test]
#[ignore = "TODO: to fix"]
async fn test_get_delivered_payloads() -> Result<(), Box<dyn std::error::Error>> {

Closes #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Use enum for handling order_by in website and API
1 participant
@0ex-d