Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate standard open option #309

Closed
Bananeweizen opened this issue Jan 1, 2025 · 1 comment · Fixed by #311
Closed

duplicate standard open option #309

Bananeweizen opened this issue Jan 1, 2025 · 1 comment · Fixed by #311

Comments

@Bananeweizen
Copy link
Contributor

@mkarg can you please check the changes from #301 for the 2 occurrences of java.nio.file.StandardOpenOption.CREATE, java.nio.file.StandardOpenOption.CREATE (yes, the same flag twice)?

<comment>Prefer java.nio.file.Files.newOutputStream(java.nio.file.Paths.get(String), java.nio.file.StandardOpenOption.CREATE, java.nio.file.StandardOpenOption.CREATE)</comment>

<comment>Prefer java.nio.file.Files.newOutputStream(java.nio.file.Path, java.nio.file.StandardOpenOption.CREATE, java.nio.file.StandardOpenOption.CREATE)</comment>

I'm wondering if that is some copy paste error and means either only one time CREATE, or CREATE + WRITE, like in some of the other rules.

@mkarg
Copy link
Contributor

mkarg commented Jan 2, 2025

Good catch! Strange but true, I was under the impression to have written CREATE, WRITE. Seems this got modified when pasting it into the PR. 😳

Anyways, feel free to post a PR changing CREATE, CREATE to CREATE, WRITE. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants