Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable timeout on gazctl gRPC calls #179

Open
rupertchen opened this issue Mar 18, 2019 · 0 comments
Open

Add configurable timeout on gazctl gRPC calls #179

rupertchen opened this issue Mar 18, 2019 · 0 comments
Assignees
Labels

Comments

@rupertchen
Copy link
Contributor

Request

Provide a way to configure the timeout in seconds for gazctl calls.

Background

If the address being dialed by gRPC is invalid, it will retry indefinitely (for a very very long time) in the background effectively hanging the tool. This is frustrating for the operator as they may wait a long time believing the server is just taking longer than usual.

Proposal

Add a global --dial-timeout that takes the time in seconds to wait to open gRPC client connections. Use a reasonably generous default (10s?) and allow 0s to mean no timeout. This should apply to both gRPC connections to the Gazette cluster or Gazette consumer shards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant