Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create suggestions with lat+lon based on geocoding #528

Open
MortenHofft opened this issue Jun 7, 2023 · 8 comments
Open

Create suggestions with lat+lon based on geocoding #528

MortenHofft opened this issue Jun 7, 2023 · 8 comments
Assignees

Comments

@MortenHofft
Copy link
Member

We have a lot of institutions without coordinates, but with an address.
using a geocoding service we can suggest latitude longitude automatically.

@ManonGros and I have agreed to give it a try on a small sample to see how well it works - both the results and the workflow of using suggestions to do this.

@MortenHofft MortenHofft self-assigned this Jun 7, 2023
@dagendresen
Copy link

dagendresen commented Jun 8, 2023

Regarding suggestion https://registry.gbif.org/institution/adef94b3-a220-439d-b9c4-e0aa6cb191ad?suggestionId=999
This institute moved office location in April 2021 from Adamstuen in Oslo to Ås outside Oslo. I tried rejecting the suggestion in GRSciColl, but got only an error message: "An error occurred An error happened while trying to process your request".

I have edited the record to update with the correct address and coordinates.

@ManonGros
Copy link
Collaborator

Thank you Dag for reporting this issue and for updating the record! I am not sure what happened, I can see that the suggestion was discarded.

@ckotwn
Copy link
Contributor

ckotwn commented Jun 12, 2023

I've applied a few suggestions(update) created for Japanese institutions. Seems working.

@ManonGros
Copy link
Collaborator

@MortenHofft, to avoid this type of issues (#530) maybe we shouldn't have the auto suggestions for entry that have external master sources?

@MortenHofft
Copy link
Member Author

to avoid this type of issues (#530) maybe we shouldn't have the auto suggestions for entry that have external master sources?

As discussed I thing that is a good idea and it was removed last week when I remembered that external sources weren't just Index Herbariorum (which was the only check I did at the time)

@ManonGros
Copy link
Collaborator

Thanks! sounds good

@elywallis
Copy link

I just reviewed the Australian Antarctic Division suggestion in the registry
Geocode suggested was latitude : -35.2824397 longitude : 149.1334837 which puts the pin in the middle of Canberra - i.e. incorrect
Google maps gives geocode at -42.98738235811778, 147.29217340713802 which correctly places the AAD in Kingston, Tasmania
I have rejected the original geocode suggested and replaced with an accurate pin

@MortenHofft
Copy link
Member Author

Thanks @elywallis - the suggestions is based on Googles geocoder, but how the address is formatted matters quite a lot for the result you get back. Sometimes searching for the title of the institution gives better results than searching for the address. Other times the reverse. Sometimes a combination is best. Other times, you need title and country.
Thanks for fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants