Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeable methods for parsers and formatters #63

Closed
OliverJAsh opened this issue Dec 3, 2021 · 1 comment · Fixed by #75
Closed

Pipeable methods for parsers and formatters #63

OliverJAsh opened this issue Dec 3, 2021 · 1 comment · Fixed by #75
Assignees
Milestone

Comments

@OliverJAsh
Copy link

OliverJAsh commented Dec 3, 2021

At the moment there is only one exported then function which works on Match, however I think we also need versions to cover Parser and Formatter (to replace the corresponding methods on those types).

Perhaps we could have separate modules for Parser, Formatter and Match. WDYT @gcanti?

@StefanoMagrassi
Copy link
Collaborator

StefanoMagrassi commented Jun 14, 2023

@OliverJAsh with the current situation (only an index.ts file) we would have the problem of names clashing.

Thus, maybe we could separate the source code in different modules and then add the pipeable version of those methods.

It shouldn't be an expensive task, but I think that we have to do some "chores" on the project (upgrade dependencies, remove tslint and so on...) before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants