Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about error report file format #421

Open
ValWood opened this issue Jan 7, 2023 · 5 comments
Open

questions about error report file format #421

ValWood opened this issue Jan 7, 2023 · 5 comments

Comments

@ValWood
Copy link

ValWood commented Jan 7, 2023

Describe the issue/bug

http://snapshot.geneontology.org/reports/pombase-report.html

SUMMARY
This report generated on 2023-01-03

Associations: 41618
Lines in file (incl headers): 44572
Lines skipped: 2949

A clear and concise description of what the bug is.

what is "Lines skipped: 2949" referring to?
this doesn't seem to correspond to reported errors?
which lines are skipped?

@kltm
Copy link
Member

kltm commented Jan 10, 2023

@ValWood As a quality of life improvement for the reports, we started suppressing ones that were considered low information or value. One of those is GORULE:0000026, which is IBA filtering. I suspect that the bulk of the skipped lines is the IBAs getting tossed.
You can see the raw reported report with http://snapshot.geneontology.org/reports/combined.report.json .
Just letting @pgaudet and @dustine32 know this is here.

@pgaudet
Copy link
Contributor

pgaudet commented Jan 10, 2023

Ideally the reports should be by source ("assigned by"), but another incremental improvement could be to also filter IEAs.

@ValWood
Copy link
Author

ValWood commented Jan 10, 2023

Filtering IBA and IEA from MOD reposts is fine, but who will report, for example, the IEA taxon violations if we cannot see them?

Personally I think I would rather see all of the errors (I can ignore, or report those assigned by others.

@pgaudet
Copy link
Contributor

pgaudet commented Jan 10, 2023

I was proposing we have a report for each source (longer term)

@ValWood
Copy link
Author

ValWood commented Jan 10, 2023

Good plan. My response was to @kltm - I didn't spot yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants