Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on format for find and replace tsv #465

Closed
vanaukenk opened this issue Mar 14, 2022 · 10 comments
Closed

Decide on format for find and replace tsv #465

vanaukenk opened this issue Mar 14, 2022 · 10 comments

Comments

@vanaukenk
Copy link

This ticket is to define the fields we want in a TSV that will be used to apply find and replaced_by changes in GO-CAMs outside of the changes that can be made based on replaced_by tags in an ontology. For example, this TSV would handle changes to RO terms used based on changes in annotation practice.

Here are 4-5 fields I can think of to include; there may be others:

  1. Existing term
  2. Replacement term
  3. Github handle of requester
  4. Link to relevant github ticket
  5. Date requested (maybe that could somehow be included automatically?)

@kltm @balhoff @cmungall - anything I'm missing or that you think is not needed? Thx.

@balhoff
Copy link
Member

balhoff commented Apr 22, 2022

@vanaukenk I would like to have two TSVs: replace_relations.tsv and replace_classes.tsv. The database change code is pretty different for the two cases. I think that format sounds sufficient.

@balhoff
Copy link
Member

balhoff commented Apr 22, 2022

My preference is to specify terms in the TSV by IRI and not by CURIE, e.g. http://purl.obolibrary.org/obo/GO_0036268 and not GO:0036268. This removes a dependency on which prefixes are configured in Minerva. Does anyone object to this?

@kltm
Copy link
Member

kltm commented Apr 22, 2022

@balhoff I suppose I'd ask how difficult/annoying that would be?
Generally, with all of the formats we consume and interact with, we use CURIEs. I think it would be nice to continue that here, unless there is an overriding difficulty or other concern.

(I'd hope that the cases we're dealing with are narrow enough we wouldn't need to involve larger mapping mechanisms.)

@balhoff
Copy link
Member

balhoff commented Apr 22, 2022

That's fine, it won't be hard to handle. I suppose the CURIE ship has sailed. :-)

@vanaukenk
Copy link
Author

Thanks @balhoff and @kltm
So, we will go with CURIEs and have two separate tsv files, one for relations and the other for classes.

@balhoff
Copy link
Member

balhoff commented Apr 25, 2022

I've pretty much got this command implemented now. One thing to decide is whether to use CURIEs in comments instead of full IRIs like I did for replace-obsolete. I thought of it as being more unambiguous, but I don't think others like it, so now I have a way to put CURIEs in the comments. If we go with CURIEs here, I think we should update the replace-obsolete command and also run a SPARQL update to edit the existing comments.

@kltm
Copy link
Member

kltm commented Apr 25, 2022

@balhoff I think that might be nice. Maybe we could touch bases at some point with @vanaukenk to talk a little about this and update-related (geneontology/noctua#766).

@vanaukenk
Copy link
Author

@kltm @balhoff
Wrt scheduling the relations updates, let's plan for the Noctua systems outage on May 12th. That will give us time to do a test run on noctua-dev to make sure everything's working as expected.

@balhoff
Copy link
Member

balhoff commented Apr 27, 2022

@vanaukenk
Copy link
Author

This work is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants