Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CARO anatomical entity with Uberon. #515

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Jun 26, 2023

Leaving the CARO root type for now. For geneontology/go-ontology#25485.

@balhoff
Copy link
Member Author

balhoff commented Jun 26, 2023

This change is merged to the dev branch.

@balhoff balhoff merged commit 9976449 into master Jul 31, 2023
@balhoff balhoff deleted the caro-to-uberon branch July 31, 2023 17:24
@tmushayahama
Copy link
Contributor

@balhoff do I need to change anything on the client side. Does this reflect on the shex document as well
@vanaukenk just to make sure, can you test, I believe CARO was hard coded into ART and also if the behavior still the same, especially ART.

@balhoff
Copy link
Member Author

balhoff commented Aug 1, 2023

@tmushayahama I think you may need to look for the Uberon term rather than the CARO term wherever you are checking root types (or, both would be safest).

@balhoff
Copy link
Member Author

balhoff commented Aug 1, 2023

@tmushayahama I have a ShEx PR: geneontology/go-shapes#302

@tmushayahama
Copy link
Contributor

@balhoff thank you. So about the ShEx, I think we have confusion of branches. The PR doesn't contain, the exclude_from_extensions which @vanaukenk made, so may branch off dev PR to dev and make it master branch. dk the workflow

@balhoff
Copy link
Member Author

balhoff commented Aug 1, 2023

@tmushayahama if you are using some other branch of go-shapes, a PR should be created to merge that into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants