-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gsudo --vt seems to have problems with character encoding #31
Comments
Thanks, I appreciate it!
I haven't yet found time to find the root cause. So, in case you want a fast-fix try this unsigned build. But I am very courious on why are you using the VT/Pseudoconsole mode. It was my first approach to gsudo, and it has never been very reliable. I quickly ran into microsoft/terminal#3765 which Microsoft is not responding and my workaroud was flagged as "A non-recommended way to fix this issue that will cause long-term application stability issues", LOL. ConHost may wrap VT sequences at the far right of the screen, breaking them. So... I've marked VT mode as deprecated and almost deleted it's code. Let me know please! |
It might be related to the lack of a ConPTY passthrough mode, the goal being to let all VT generated by client apps be unmolested by the plumbing: microsoft/terminal#1173 |
Closing as VT mode is deprecated. |
I got an answer on microsoft/terminal#3765. It was a silly mistake on my end. So I started looking into this: The real issue here is this is missing line: |
First up, great work Gerardo. Superb, in fact. Now, on to the issue at hand:
As you can see,
gsudo
without conpty is fine. But with--vt
for conpty, the extended unicode characters are getting corrupted/munged somehow. I don't think this is an issue with conpty since WT itself uses conpty in general, and unicode works fine (obviously.)Let me know if you need any more information. I'm using Fira Code as a font.
The text was updated successfully, but these errors were encountered: