This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Create new controller per request #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gernest
reviewed
Oct 25, 2016
| @@ -213,8 +213,8 @@ func RegisterModels(models ...interface{}) { | |||
| } | |||
|
|
|||
| // RegisterController registers a controller in the global utron App. | |||
| func RegisterController(ctrl Controller, middlewares ...interface{}) { | |||
| _ = baseApp.router.Add(ctrl, middlewares...) | |||
| func RegisterController(ctrlfn func() Controller, middlewares ...interface{}) { | |||
There was a problem hiding this comment.
Can we improve this a little bit. This is going to break the API.
Maybe wrap the ctrl to a func that returns a new instance of ctrl everytime it is called?
This will keep everything working and fix the issue altogether.
There was a problem hiding this comment.
I don't understand how i can do it) What do you mean?
There was a problem hiding this comment.
I fixed it myself, based on your changes. 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't write a tests! #67