Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled network errors while retrieving end-user yarn dependencies #545

Open
dustinbyrne opened this issue Dec 2, 2022 · 3 comments
Open
Labels
bug Something isn't working

Comments

@dustinbyrne
Copy link
Contributor

dustinbyrne commented Dec 2, 2022

  • RequestError: unable to get local issuer certificate
  • RequestError: self signed certificate in certificate chain
    Our option here is to either:
    • disable strict SSL verification, thereby ignoring certificate errors (enableStrictSsl: false) - I don't think we should do this.
    • prompt the user to specify a path to the CA signing certificate (caFilePath)

RequestError: getaddrinfo ENOTFOUND
RequestError: getaddrinfo EAI_AGAIN
RequestError: connect ETIMEDOUT
RequestError: connect ECONNREFUSED
Corporate firewall? Proxy configuration necessary?

The easiest path forward may be to provide a workaround via manual installation.

Plan:

  • Give the user a good error message
  • Prevent cascading failures for subsequent telemetry messages (lots more errors happen after this once it occurs)
  • Change the telemetry to not post it to Slack (once the above is done)
@dustinbyrne dustinbyrne added the bug Something isn't working label Dec 2, 2022
@ahtrotta
Copy link
Contributor

Here's another one:

RequestError: write EPROTO 31273096:error:10000410:SSL routines:OPENSSL_internal:SSLV3_ALERT_HANDSHAKE_FAILURE:../../third_party/boringssl/src/ssl/tls_record.cc:594:SSL alert number 40

@symwell
Copy link
Contributor

symwell commented Jan 6, 2023

Another one:

Stdout: ➤ YN0001: │ RequestError: unable to verify the first certificate

Slack
log

Error: Failed to install dependencies
Exit code: 1
Signal: null
Stdout: ➤ YN0000: ┌ Resolution step

Stdout: ➤ YN0001: │ RequestError: unable to verify the first certificate
at ClientRequest.<anonymous> (c:\Users\TEST\AppData\Roaming\Code\User\globalStorage\appland.appmap\yarn.js:222:14361)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:402:35)
at ClientRequest.o.emit (c:\Users\TEST\AppData\Roaming\Code\User\globalStorage\appland.appmap\yarn.js:217:90453)
at TLSSocket.socketErrorListener (node:_http_client:447:9)
at TLSSocket.emit (node:events:390:28)
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at processTicksAndRejections (node:internal/process/task_queues:83:21)
at TLSSocket.onConnectSecure (node:_tls_wrap:1530:34)
at TLSSocket.emit (node:events:390:28)
at TLSSocket._finishInit (node:_tls_wrap:944:8)
at TLSWrap.ssl.onhandshakedone (node:_tls_wrap:725:12)

Stdout: ➤ YN0000: └ Completed in 0s 551ms
➤ YN0000: Failed with errors in 0s 556ms

at ChildProcess.<anonymous> (\out\extension.js:39013:32)
at Object.onceWrapper (node:events:510:26)
at ChildProcess.emit (node:events:402:35)
at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)

@symwell
Copy link
Contributor

symwell commented Jan 6, 2023

Another one:

RequestError: read ECONNRESET

Slack
log

Error: Failed to install dependencies
Exit code: 1
Signal: null
Stdout: ➤ YN0000: ┌ Resolution step

Stdout: ➤ YN0001: │ RequestError: read ECONNRESET
at ClientRequest.<anonymous> (c:\Users\TEST\AppData\Roaming\Code\User\globalStorage\appland.appmap\yarn.js:222:14361)
at Object.onceWrapper (node:events:646:26)
at ClientRequest.emit (node:events:538:35)
at o.emit (c:\Users\TEST\AppData\Roaming\Code\User\globalStorage\appland.appmap\yarn.js:217:90453)
at TLSSocket.socketErrorListener (node:_http_client:442:9)
at TLSSocket.emit (node:events:526:28)
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
at TLSWrap.onStreamRead (node:internal/stream_base_commons:217:20)

Stdout: ➤ YN0000: └ Completed in 2m 12s
➤ YN0000: Failed with errors in 2m 12s

at ChildProcess.<anonymous> (\out\extension.js:39013:32)
at Object.onceWrapper (node:events:646:26)
at ChildProcess.emit (node:events:538:35)
at ChildProcess._handle.onexit (node:internal/child_process:291:12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants