Windows problems

[ghLoser]

Extracting the header from files with windows line endings (CRLF) fails.
It would be great if the respective functions were less strict, e.g. by removing all CR characters before parsing.

[rhukster]

Is there an exact error you are getting? Are there any special steps you did that we would need to follow t recreate? Thanks.

[ghLoser]

No error is thrown, but all header fields are ignored in a .md-file with CRLF line endings.
Easy to test with a template or title field, both will have no effect.

[rhukster]

Could you please let me know what server setup you have? Is it a WAMP stack? Just would like to try to replicate as closely as possible. Cheers.

[ghLoser]

It's a WNMP stack with Nginx 1.7.4 and PHP 5.5.15 (Non Thread Safe + FastCGI)

https://github.com/wnmp/wnmp
http://www.getwnmp.org/

[rhukster]

Well I think it's probably an Nginx issue. I just tried with EasyPHP and it works fine when I edit a file in Notepad++.

We did some preliminary testing with Nginx, hence the configuration file we've included with Grav. However, this is not thoroughly tested as we don't use it ourselves for development. Throw windows in to that mix too, and that's very uncharted territory for us.

Of course we want to ensure Grav runs on as many platforms and configurations as possible, so any help here identifying what is the cause and how to fix it would be helpful. Unfortunately we're all mac users, and windows is pretty foreign to us. Took me 30 mins to even get EasyPHP to run! Should be easy right? but i couldn't even find where the files were, and then i had to restart the VM to get it to run at all :(

[ghLoser]

No sweat, just wanted to let you know :)

[mahagr]

I'm going to reopen this one for now in case if someone else has some insights to the issue.

[ghLoser]

Got it.
In Markdown.php, function decode(), line 109 all CRLFs and/or CRs are substituted with LFs, but in line 112 the original, unprocessed string is used.

So replacing
preg_match("/---\n(.+?)\n---(\n\n|$)/uism", $this->raw(), $m);
with
preg_match("/---\n(.+?)\n---(\n\n|$)/uism", $var, $m);
works for me.

Sorry, too dumb to make a pull request...

[rhukster]

Ok great find! Pull requests are simple, just browse to the source of the page:

https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Filesystem/File/Markdown.php

Click the edit icon and make your change, then comment and commit and a pull request is automatically made.

[ghLoser]

Thanks a lot, pull request created.

[rhukster]

OK thanks, tested and works fine in our test setups. Merged 👍