Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (0238abd) to head (17771a0).
Report is 8 commits behind head on master.

@@           Coverage Diff           @@
##           master    #8515   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files        1229     1229           
  Lines      106421   106435   +14     
=======================================
+ Hits        98576    98590   +14     
  Misses       7845     7845           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi @jflim, would you mind adding some tests for this? It looks good to me, but it would still be nice to have some validation that this is correct

The test actually found an issue with the urls, so I'm glad I tested now 🌞 Retested with OpenSearch tests and tagging tests for opensearch and es.

I'm a bit confused as to why this fix works though. I believe I observed that remove_tags for OpenSearch was also matching the /2021-01-01/tags/? regex but from my understanding the ? was to handle if a URL ends with / or not.

I'm a bit confused as to why this fix works though. I believe I observed that remove_tags for OpenSearch was also matching the /2021-01-01/tags/? regex but from my understanding the ? was to handle if a URL ends with / or not.

Looks like this is because we don't do a fullmatch. So ../tags is actually interpreted as ../tags.* - which also matches ../tags-removal.

Thank you for the PR!