Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canceling porter should cancel the invocation image #2234

Open
carolynvs opened this issue Jul 7, 2022 · 2 comments · May be fixed by #3253
Open

Canceling porter should cancel the invocation image #2234

carolynvs opened this issue Jul 7, 2022 · 2 comments · May be fixed by #3253
Labels
bug Oops, sorry!

Comments

@carolynvs
Copy link
Member

Describe the bug

When I realize that a bundle is "hung" and won't finish, I would like to be able to use CTRL+C to stop porter AND the bundle from continuing to run.

To Reproduce

  1. Create a bundle that just has a really long sleep in it
  2. Run porter install
  3. Use CTRL+C to abort porter install.

Only porter stops, the invocation image keeps going uninterrupted, and then the records aren't persisted for the run.

Expected behavior

The invocation image should stop too. If we can do anything to mark the run as failed that's great, but no one should be having to use docker rm to get rid of dangling invocation images.

Version

1.0.0-beta.1
@carolynvs carolynvs added the bug Oops, sorry! label Jul 7, 2022
@maganvill
Copy link

Confirmed to still exists two years later.

The porter execute step does not receive a SIGTERM signal, or any other signal when Ctrl-C is entered by user and Porter says "cancel requested".

When entering Ctrl+C again Porter says "hard interrupt received, bye!" and exits, but the docker image is still running...

@dgannon991
Copy link
Member

I'll bring this one up at the community meeting this week if I can. I've found where this is happening, but without some changes to the CNAB-go library we use, I'm not sure how we could get around this? (There might be some fancy tricks that @schristoff knows though, so I'll wait for feedback :))

This was referenced Nov 14, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Oops, sorry!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass in context to cnab-go Run() dgannon991/getporter-porter
3 participants
@carolynvs @dgannon991 @maganvill