Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trimming of spans #3880

Closed
iambriccardo opened this issue Jul 31, 2024 · 1 comment · Fixed by #3877
Closed

Fix trimming of spans #3880

iambriccardo opened this issue Jul 31, 2024 · 1 comment · Fixed by #3877
Assignees
@jjbayer @iambriccardo

Comments

@iambriccardo
Copy link
Member

iambriccardo commented Jul 31, 2024 •
edited
Loading

This PR (#3645) introduced a maximum size for spans, resulting in redactions of the contents of the span that effectively introduced problems with metrics because some fields are redacted and later used for tags in the metric.
@iambriccardo iambriccardo self-assigned this Jul 31, 2024
@iambriccardo iambriccardo mentioned this issue Jul 31, 2024
Merged
@jjbayer jjbayer reopened this Aug 2, 2024
@jjbayer jjbayer self-assigned this Aug 2, 2024
@jjbayer
Copy link
Member

jjbayer commented Aug 2, 2024

Reopening because we're seeing snuba and relay errors again, just like we saw before #3670.

@jjbayer jjbayer mentioned this issue Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjbayer jjbayer

@iambriccardo iambriccardo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(process-value): Add object level trimming getsentry/relay
2 participants
@jjbayer @iambriccardo