Skip to content

Commit

Permalink
meta(nuxt): Require minimum Nuxt v3.7.0 (#14473)
Browse files Browse the repository at this point in the history
This PR adds a minimum required version for the Nuxt SDK. Version 3.7.0
was selected because this version adds the possibility to set client
source maps to `'hidden'` ([PR
here](nuxt/nuxt#22787)).

However, as the SDK relies on other versions as well (see below, at the
bottom), those packages need to be manually bumped (in case the
lock-file is not updated yet). **Nuxt 3.7.0** at least supports the
correct version range:
["nitropack":
"^2.6.1"](https://github.com/nuxt/nuxt/blob/v3.7.0/packages/nuxt/package.json#L84)
["ofetch":
"^1.3.3"](https://github.com/nuxt/nuxt/blob/v3.7.0/packages/nuxt/package.json#L87)

Above **Nuxt v3.14.0**, everything works out of the box, as the versions
are already updated:
["nitropack":
"^2.10.2"](https://github.com/nuxt/nuxt/blob/v3.14.0/packages/nuxt/package.json#L97)
["ofetch":
"^1.4.1"](https://github.com/nuxt/nuxt/blob/v3.14.0/packages/nuxt/package.json#L100)

#### Minimum versions, the SDK relies on:
- `nitropack` 2.10.0: for the correct peerDependency of `@vercel/nft`
- `ofetch` 1.4.0: for being able to patch `$fetch`
  • Loading branch information
s1gr1d authored Nov 26, 2024
1 parent 973ef9c commit 23e3783
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nuxt-3-min",
"description": "E2E test app for the minimum nuxt 3 version our nuxt SDK supports.",
"description": "E2E test app for the minimum Nuxt 3 version our Nuxt SDK supports.",
"private": true,
"type": "module",
"scripts": {
Expand All @@ -16,15 +16,15 @@
},
"dependencies": {
"@sentry/nuxt": "latest || *",
"nuxt": "3.13.2"
"nuxt": "3.7.0"
},
"devDependencies": {
"@nuxt/test-utils": "^3.14.1",
"@playwright/test": "^1.44.1",
"@sentry-internal/test-utils": "link:../../../test-utils"
},
"overrides": {
"nitropack": "2.9.7",
"@vercel/nft": "^0.27.4"
"nitropack": "2.10.0",
"ofetch": "1.4.0"
}
}
2 changes: 1 addition & 1 deletion packages/nuxt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"access": "public"
},
"peerDependencies": {
"nuxt": "3.x"
"nuxt": ">=3.7.0 || 4.x"
},
"dependencies": {
"@nuxt/kit": "^3.13.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/nuxt/src/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default defineNuxtModule<ModuleOptions>({
name: '@sentry/nuxt/module',
configKey: 'sentry',
compatibility: {
nuxt: '^3.0.0',
nuxt: '>=3.7.0',
},
},
defaults: {},
Expand Down

0 comments on commit 23e3783

Please sign in to comment.