Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.2 support to README. #2159

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

natikgadzhi
Copy link
Contributor

Please don't ban me for 4-character PRs 🙈

This PR adds Ruby 3.2 note to the README. Originally, Ruby 3.2 was added to CIs in #2052 by @st0012.

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍

sentry-ruby/README.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #2159 (6661af1) into master (7a65d3f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2159   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          97       97           
  Lines        3638     3638           
=======================================
  Hits         3541     3541           
  Misses         97       97           
Components Coverage Δ
sentry-ruby 98.02% <ø> (ø)
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 93.70% <ø> (ø)
sentry-resque 93.65% <ø> (ø)
sentry-delayed_job 94.36% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)

@natikgadzhi
Copy link
Contributor Author

Hmmm, CI check demands the changelog entry, but I think it's not required here, right?

@st0012
Copy link
Collaborator

st0012 commented Nov 4, 2023

@natikgadzhi Nah it's fine. I'll merge it now 👍

@st0012 st0012 merged commit e675c58 into getsentry:master Nov 4, 2023
96 of 97 checks passed
@natikgadzhi
Copy link
Contributor Author

FWIW, I like your more concise version. Promise to make my PRs higher value in the future <3 Thank you for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants