-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot setup for latest Symfony5.2.x #446
Comments
I think it's related to https://github.com/symfony/psr-http-message-bridge/releases/tag/v2.1.0 |
Albeit the error is slightly different, I think it's still related to #379. I've added a warning notice in the README about it a few days ago 😉 |
@ste93cry , thanks. I found https://github.com/getsentry/sentry-symfony/tree/develop#optional-use-custom-http-factorytransport but it should be linked/referenced from/to https://github.com/getsentry/sentry-symfony/tree/develop#installation-with-symfony-flex-symfony-4-or-newer as well. |
I'm not sure I understand what the customization of the HTTP factory/transport has to do with the issue you have, so I assume you wanted to write the link to the notice which is present in the |
@ste93cry , ah, I missed it as it was added to non-Flex installation instruction. But flex installations are affected as well |
Right 😃 When I added it at the bottom of the install instructions the intention was not to mean that it was affecting just the non-Flex method, but it looks so because it has no proper section title. A PR to move the notice around so that it's either more prominent or more clear about it affecting both ways of installation is welcome. Not sure which solution is the best though, since giving it a big header imho is not appropriate as it's a warning and not a section of the README |
Looks like the installation process could be a little bit revised and made the single merged version:
That's just my humble opinion and not the proper solution :) Sorry, I'm not going to make a PR for that because of lack of knowledge what's going on and pretty generic english skills :) |
I've opened a PR to improve the README. Give it a look if you want and let me know what you think 😉 In the meanwhile, I think we can close this, can't I? |
Fixed in #452 |
Environment
How do you use Sentry?
Sentry SaaS (sentry.io)
Which SDK and version?
Bundled
Steps to Reproduce
composer require sentry/sentry-symfony dev-master
Expected Result
Success installation
Actual Result
Quick digging gets me an idea of having prerequisite step
composer require nyholm/psr7
. Worked then.The text was updated successfully, but these errors were encountered: