Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to override release artifacts #3355

Closed
mitsuhiko opened this issue May 28, 2016 · 9 comments
Closed

Add a flag to override release artifacts #3355

mitsuhiko opened this issue May 28, 2016 · 9 comments
Assignees

Comments

@mitsuhiko
Copy link
Member

Add a way to make the release file upload idempotent by replacing whatever is already there if needed.

@mitsuhiko mitsuhiko self-assigned this May 28, 2016
@dcramer dcramer changed the title Add a flat to override release artifacts Add a flag to override release artifacts May 30, 2016
@neiker
Copy link

neiker commented Oct 18, 2016

This is very necessary!

@mjracca
Copy link

mjracca commented Oct 18, 2016

+1

@mgiachetti
Copy link

We need this to update source maps for a react-native app.

@mitsuhiko
Copy link
Member Author

@mgiachetti can you clarify this a bit?

@mgiachetti
Copy link

mgiachetti commented Jan 3, 2017

@mitsuhiko
We are using sentry for production and for our testing environment.
In production we create a new release every time the code changes so here we do not have problems because we do not need to update any artifact.
For our testing environment we have one release for every pull request so all issues are grouped in the same release.
Every time the pull request is updated a new version of the source maps need to be pushed and we need to update the existing source map artifact.

The current api doesn't support update an artifact just create and if the file already exists it fails.
So it would be awesome if you could add a flag to the create file endpoint.

this is how we are using the endpoint:

# Upload the source map
$ curl https://sentry.io/api/0/projects/$ORGANIZATION/$PROJECT/releases/$RELEASE/files/ \
  -X POST \
  -H 'Authorization: Bearer $TOKEN' \
  -F [email protected] \
  -F name="/main.jsbundle.map"

We could create a new release for each time a pull request change, but this will be unmanageable, for the amount of new releases. also the issues would not be grouped under the same release.

@mitsuhiko
Copy link
Member Author

@mgiachetti did you see the sentry-cli binary? It deals with all of this automatically and also supports sourcemap rewriting which is necessary for latest react-native versions from what i can tell (though that part is not documented yet. But we're trying to work on that atm).

@mgiachetti
Copy link

@mitsuhiko nice cli!
I didn't know that, but the cli can replace an existing source map on sentry's server?
As far as I know the api doesn't support to replace an artifact. You need to delete the file first then upload the new one.
The cli does that automatically. Nice!
Thanks you for your help!

@squalvj
Copy link

squalvj commented Feb 10, 2020

+1

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants