-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replay: IP address showing 0.0.0.0
without filter enabled
#43509
Comments
If the IP is stripped could a tag be used to display some relevant information? Instead of the 0 icon and 0.0.0.0 |
Is there a way to title the session? I'd prefer to have datetime or something like that... |
Experiencing same result |
This is probably a display error. The data was written to clickhouse correctly. If the issue re-appears after we deploy let me know! |
Did anyone in this issue (other than Bruno) have ip-address scrubbing disabled and saw this behavior? E.g. we returned an empty ip (0.0.0.0) but you expected the user's ip-address to be present? |
Hey everyone. We think we've solved the problem and hopefully we'll have something deployed soon. The two relevant PRs are linked to this issue. tl;dr we weren't handling ip-addresses properly on ingest and we were not returning them properly on the HTTP API. Going forward you'll see the ip-addresses populated. If you enabled ip-address scrubbing you should see a pleasing fallback identifier. Unfortunately, because this was an ingest error, your historical replays will not have an ip-address associated and will have to use the fallback. Sorry about that! If the problem persists (once this issue is closed) please feel free to re-open this one or create a new one. |
I am seeing this in a project of mine too. I can help reproduce if necessary. |
I am also seeing the initial issue reported. I was trying to understand where the ip stripping is done but I believe my project is not stripping it. Can someone look into this? |
@cmanallen did the fix get shipped? I can also reproduce it. Example: https://nugettrends.sentry.io/settings/projects/spa/security-and-privacy/ |
@bruno-garcia No it unfortunately hasn't shipped yet. This issue auto-closed when one PR was merged. There's a PR on getsentry/relay that needs to be merged. |
This is the pull that will fix the ip-address issue for anyone whose interested in following the progress: getsentry/relay#1805 |
Should be done. We'll get |
I was getting the server’s IP (I’m tunneling and not forwarding X-Forwarded-For) and now I see 0.0.0.0This is a result of PII stripping added recently, right?
The project doesn’t have any custom filters in Settings. On Security & Privacy tab it doesn’t have Prevent Storing of IP Addresses
Expected Result
Be able to control IP address stripping
The text was updated successfully, but these errors were encountered: