Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay: IP address showing 0.0.0.0 without filter enabled #43509

Closed
bruno-garcia opened this issue Jan 20, 2023 · 12 comments · Fixed by #43920 or getsentry/relay#1805
Closed

Replay: IP address showing 0.0.0.0 without filter enabled #43509

bruno-garcia opened this issue Jan 20, 2023 · 12 comments · Fixed by #43920 or getsentry/relay#1805
Assignees

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Jan 20, 2023

I was getting the server’s IP (I’m tunneling and not forwarding X-Forwarded-For) and now I see 0.0.0.0This is a result of PII stripping added recently, right?
The project doesn’t have any custom filters in Settings. On Security & Privacy tab it doesn’t have Prevent Storing of IP Addresses

image

image

image

Expected Result

Be able to control IP address stripping

@nunucardoso
Copy link

nunucardoso commented Jan 25, 2023

If the IP is stripped could a tag be used to display some relevant information? Instead of the 0 icon and 0.0.0.0

@zapic0
Copy link

zapic0 commented Jan 26, 2023

Is there a way to title the session? I'd prefer to have datetime or something like that...

@LKNSI
Copy link

LKNSI commented Jan 27, 2023

Experiencing same result

@cmanallen
Copy link
Member

This is probably a display error. The data was written to clickhouse correctly. If the issue re-appears after we deploy let me know!

@cmanallen
Copy link
Member

Did anyone in this issue (other than Bruno) have ip-address scrubbing disabled and saw this behavior? E.g. we returned an empty ip (0.0.0.0) but you expected the user's ip-address to be present?

@cmanallen
Copy link
Member

Hey everyone. We think we've solved the problem and hopefully we'll have something deployed soon. The two relevant PRs are linked to this issue. tl;dr we weren't handling ip-addresses properly on ingest and we were not returning them properly on the HTTP API.

Going forward you'll see the ip-addresses populated. If you enabled ip-address scrubbing you should see a pleasing fallback identifier. Unfortunately, because this was an ingest error, your historical replays will not have an ip-address associated and will have to use the fallback. Sorry about that!

If the problem persists (once this issue is closed) please feel free to re-open this one or create a new one.

@lforst
Copy link
Member

lforst commented Feb 6, 2023

I am seeing this in a project of mine too. I can help reproduce if necessary.

@nunucardoso
Copy link

I am also seeing the initial issue reported. I was trying to understand where the ip stripping is done but I believe my project is not stripping it. Can someone look into this?

@bruno-garcia bruno-garcia reopened this Feb 9, 2023
@bruno-garcia
Copy link
Member Author

@cmanallen
Copy link
Member

cmanallen commented Feb 9, 2023

@bruno-garcia No it unfortunately hasn't shipped yet. This issue auto-closed when one PR was merged. There's a PR on getsentry/relay that needs to be merged.

@cmanallen
Copy link
Member

This is the pull that will fix the ip-address issue for anyone whose interested in following the progress: getsentry/relay#1805

@cmanallen
Copy link
Member

Should be done. We'll get 0.0.0.0 values translated to something more useful soon. But I think the issue of all the ip-addresses being this value should be solved.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants