Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in p3 colorspace do not show up in the PiP window #7

Open
jordibruin opened this issue Jul 2, 2022 · 2 comments
Open

Images in p3 colorspace do not show up in the PiP window #7

jordibruin opened this issue Jul 2, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@jordibruin
Copy link

FYI, we just discovered that images in P3 colorspace don't work for some reason.
image

@jordibruin
Copy link
Author

SRGB Colorspace
rafi-head-rgb.pdf

P3 Colorspace
rafi-head.pdf

@Sherlouk
Copy link
Contributor

Sherlouk commented Jul 2, 2022

For anybody stumbling across this discussion, Jordi and I have identified the issue and raised it as FB10531954 and FB10531882 on Apple's feedback tracker.

The bug appears to be within the ImageRenderer which we utilise to convert the SwiftUI view to an image. Given this is new in iOS 16, I hope this will be fixed in an upcoming beta and will keep an eye on this.

In the meanwhile we have identified two possible workarounds:

  1. Use a supported colour space/file format (PNG using RGB colour space appears to work fine)
  2. Wrap your images in UIImage first before passing to SwiftUI: Image(uiImage: UIImage(named: "XX")!)

@Sherlouk Sherlouk added the bug Something isn't working label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants