Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Pluto #1790

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

@whirmill
Copy link
Author

the missing folders warnings are handled in the pre-start hook.
the discovery service needs to be on the host network.

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ pluto/docker-compose.yml Service "discovery" uses host network mode:
The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@whirmill
Copy link
Author

whirmill commented Nov 13, 2024

what's next?

@nmfretz
Copy link
Contributor

nmfretz commented Nov 13, 2024

Thanks for this submission @whirmill, and for making changes based on the linter!

We've got our head down elsewhere right now, but will try and review this next week. Thanks for your patience.

@whirmill whirmill changed the title Added Pluto app App Submission: Pluto Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants