Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created standalone package of Core-logic and dropped .NET Core 2.1 #93

Merged
merged 11 commits into from
Dec 1, 2021

Conversation

gfoidl
Copy link
Owner

@gfoidl gfoidl commented Nov 30, 2021

  • the core-logic is extracted into a new package trx2junit.Core which will be consumed by tool
  • dropped support for .NET Core 2.1 as it reached end of life on 21.08.2021
  • besides that only internal changes were done -- the usage of the tool trx2junit won't be affected

Fixes #92

@gfoidl gfoidl added this to the v2.0.0 milestone Nov 30, 2021
@gfoidl
Copy link
Owner Author

gfoidl commented Nov 30, 2021

Ah, CI means

##[warning]No test result files matching tests/trx2junit.Tests/TestResults/*.trx were found.

🙈

@gfoidl
Copy link
Owner Author

gfoidl commented Nov 30, 2021

@dstahl-axion here's my stab on it.

Please try it with the instructions below, and tell me if it fits your needs. Then I'd like to create a real release of it.

For the package see trx2junit.Core v2.0.0-preview-1
The feed is https://pkgs.dev.azure.com/gh-gfoidl/github-Projects/_packaging/gfoidl-public/nuget/v3/index.json (more info in the link above).

For the tool:

# deinstall current version
dotnet tool uninstall -g trx2junit

# install preview
dotnet tool install -g trx2junit --version 2.0.0-preview-1 --add-source https://pkgs.dev.azure.com/gh-gfoidl/github-Projects/_packaging/gfoidl-public/nuget/v3/index.json

A bit a description is in the ReadMe of the PR.

@dstahl-axion
Copy link

@gfoidl Wow that was fast!

I've just tested these scenarios on two TRX files. One created from .net framework test assemblies and one created from .net5 test assemblies. I ran the latest published tool, the pre-release tool, and my own code using your trx2junit.Core nuget package.

All produced the same output after the same runtime.

This works exactly as I need it to and solves my needs perfectly. Thanks so much for the quick implementation!

@gfoidl
Copy link
Owner Author

gfoidl commented Dec 1, 2021

You're welcome 😄

Thanks for confirmation, so I'm going to make the official release.

@gfoidl gfoidl merged commit 7db08ec into master Dec 1, 2021
@gfoidl gfoidl deleted the core-package branch December 1, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release main library separately?
2 participants