get_open_files errors on OS X

[giampaolo]

From [email protected] on August 06, 2010 02:13:17

======================================================================
FAIL: test_get_open_files (__main__.TestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_psutil.py", line 372, in test_get_open_files
    self.assertTrue(thisfile in files)
AssertionError: False is not True

======================================================================
FAIL: test_get_open_files (__main__.LimitedUserTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_psutil.py", line 372, in test_get_open_files
    self.assertTrue(thisfile in files)
AssertionError: False is not True

----------------------------------------------------------------------

Original issue: http://code.google.com/p/psutil/issues/detail?id=104

[giampaolo]

From [email protected] on August 05, 2010 17:14:41

Status: Accepted

[giampaolo]

From [email protected] on August 05, 2010 17:54:35

Ok, r629 includes fixes for the above errors. However, after doing 
that I am still getting test suite errors for get_-open_files(): 

======================================================================
FAIL: test_get_open_files (__main__.TestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_psutil.py", line 394, in test_get_open_files
    self.assertTrue(os.path.isfile(file))
AssertionError: False is not True

======================================================================
FAIL: test_get_open_files (__main__.LimitedUserTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_psutil.py", line 394, in test_get_open_files
    self.assertTrue(os.path.isfile(file))
AssertionError: False is not True

----------------------------------------------------------------------

In this case I did some debugging and it's happening because of 
temporary files open by one of my processes. Since they're transient 
temporary files, they only exist for seconds or possibly even less 
time. As a result, by the time we check to see if it's a valid file, it's already gone. 

I suggest we remove/replace these tests, as this is likely to happen 
pretty frequently for any process that uses temporary files.

[giampaolo]

From g.rodola on August 05, 2010 17:59:30

I agree the test is unreliable and should be removed.

[giampaolo]

From [email protected] on August 10, 2010 19:17:08

did this test get removed? If so let's go ahead and close out this 
issue as fixed with my changes to the lsof parser

[giampaolo]

From [email protected] on September 20, 2010 16:12:17

For now I've disabled these in the test suite in OS X until we have 
time to fix the parsing code.

[giampaolo]

From [email protected] on September 20, 2010 16:12:36

Labels: Type-Enhancement

[giampaolo]

From g.rodola on November 11, 2010 15:00:46

Re-enabled for OSX in r782 .

Status: Fixed

[giampaolo]

From g.rodola on March 02, 2013 03:53:56

Updated csets after the SVN -> Mercurial migration: r629 == revision 
b8eb30709b31 r782 == revision 0128cc5e790b