From 5b708ad5a5ddddbd9194ba7a04c9ab3cf3f9db32 Mon Sep 17 00:00:00 2001 From: Giovanni Bassi Date: Wed, 1 Nov 2023 02:30:47 -0300 Subject: [PATCH] Add tests for Node.js version 21 --- .devcontainer/Dockerfile | 4 ++-- .github/workflows/build.yml | 6 +++--- testInstall.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 71eb4ba..f403ade 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -14,6 +14,6 @@ RUN echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \ && chmod 0440 /etc/sudoers.d/$USERNAME USER $USERNAME RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash -RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 18.18.0 && nvm i --no-progress 20.7.0" ] -RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 20" ] +RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 18.18.0 && nvm i --no-progress 20.7.0 && nvm i --no-progress 21.1.0" ] +RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 21" ] ENV DEBIAN_FRONTEND=dialog diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ac388b1..8396dc3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,7 +36,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["18.x", "20.x"] + node: ["18.x", "20.x", "21.x"] runner: ["windows-latest", "ubuntu-latest", "macos-latest"] steps: - uses: actions/checkout@v4 @@ -72,7 +72,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["18", "20"] + node: ["18", "20", "21"] steps: - uses: actions/checkout@v4 - uses: uraimo/run-on-arch-action@v2.5.1 @@ -116,7 +116,7 @@ jobs: strategy: fail-fast: false matrix: - node: ["18", "20"] + node: ["18", "20", "21"] steps: - uses: actions/checkout@v4 - uses: uraimo/run-on-arch-action@v2.5.1 diff --git a/testInstall.js b/testInstall.js index 7443ab8..b2114e0 100755 --- a/testInstall.js +++ b/testInstall.js @@ -6,7 +6,7 @@ const os = require('os'); const path = require('path'); const fs = require('fs'); const spawnSync = require('child_process').spawnSync; -const versions = ['18', '20']; +const versions = ['18', '20', '21']; const tempInstallPath = path.resolve(os.tmpdir(), 'chromedriver-test'); const packedFile = path.resolve(tempInstallPath, 'chromedriver.tgz');