New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuredfilePath being set, should not hit the network #131

Open

stefanpenner opened this issue Nov 15, 2017 · 0 comments

Labels

bug up-for-grabs

stefanpenner commented Nov 15, 2017

Even if configuredfilePath is set, we still hit the CDN for the latest version.

node-chromedriver/install.js

Lines 51 to 54 in 700ba53

    
           promise = promise.then(function () { 
        
             if (chromedriver_version === 'LATEST') 
        
               return getLatestVersion(getRequestOptions(cdnUrl + '/LATEST_RELEASE')); 
        
           });

giggio added the bug label

giggio added the up-for-grabs label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment