Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chromedriver.start() timeout configurable #193

Open
Janpot opened this issue Mar 8, 2019 · 1 comment
Open

Make chromedriver.start() timeout configurable #193

Janpot opened this issue Mar 8, 2019 · 1 comment

Comments

@Janpot
Copy link

Janpot commented Mar 8, 2019

Since #177 you can make .start return a promise. But the timeout of waiting for an available port seems to be fixed at 10s. I propose to make this call more flexible so that a different timeout can be configured. Maybe it can look like

await chromedriver.start({
  args: [ 'some-arg' ],
  timeout: 30000
});

or

await chromedriver.start([ 'some-arg' ], {
  timeout: 30000
});

Would you be interested in accepting a PR for that?

@giggio
Copy link
Owner

giggio commented Apr 16, 2019

Yes, but it would be better to support options. Like so:

chromedriver.start(args, opts);

Where opts is type boolean | { timeout: number }.
Then the start method has to be changed to understand the type and we can configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants