Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 support #346

Closed
jasquat opened this issue Jul 19, 2022 · 5 comments · Fixed by #386
Closed

React 18 support #346

jasquat opened this issue Jul 19, 2022 · 5 comments · Fixed by #386
Labels
enhancement New feature or request

Comments

@jasquat
Copy link

jasquat commented Jul 19, 2022

This project looks great and we would love to use it but we are using react 18 and so far this project only supports 16 and 17. I'm wondering if there are any plans to support react 18. This project does have a few dependencies like react-beautiful-dnd that also require 16 or 17 which may make this support harder but still may be doable.

If there are no plans, has anyone else been able to get this working with react 18 or have advice on how to do so? I'm still pretty new to react so any advice would be appreciated.

Thanks,

@raymond-lam raymond-lam added the enhancement New feature or request label Jul 20, 2022
@raymond-lam
Copy link
Collaborator

You are right that this project has dependencies that do not appear to support React 18. We'll see what we can do.

@zngly-vlad
Copy link

Currently I am getting around this by using --legacy-peer-deps but this is not ideal.

@crates
Copy link

crates commented Sep 7, 2022

@jasquat / @raymond-lam -
Looks like Atlassian released support for React 18 on react-beautiful-dnd eight days ago.

https://github.com/atlassian/react-beautiful-dnd/releases/tag/v13.1.1

Which other peer dependencies don't support v18 at this time? I'll keep an eye on them.

@jasquat
Copy link
Author

jasquat commented Sep 7, 2022

That is great news. I will take a look at this today.

@jasquat
Copy link
Author

jasquat commented Sep 7, 2022

Testing this out, I'm now getting this error when trying to load the FormBuilder:

List.js:31 Uncaught TypeError: Cannot assign to read only property 'name' of function 'function t(t) {
    var e = S({}, t);
    return delete e.ref, n(e, t.ref || null);
  }'
    at ./node_modules/reactstrap/dist/reactstrap.modern.js (List.js:31:1)
    at options.factory (react refresh:6:1)
    at __webpack_require__ (bootstrap:24:1)
    at fn (hot module replacement:62:1)
    at ./node_modules/@ginkgo-bioworks/react-json-schema-form-builder/dist/index.modern.js (index.es.js:426:1)
    at options.factory (react refresh:6:1)
    at __webpack_require__ (bootstrap:24:1)
    at fn (hot module replacement:62:1)

We are using:

  • react-json-schema-formbuilder: 2.9.2
  • boostrap: 5.2.1
  • react: 18.2.0
  • reactstrap: 9.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants