We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I don't think it's docker-py's burden to do anything other than ' '.join(container_args)
' '.join(container_args)
If our transforms return strings that might have spaces, they also need to be quoted.
Also random note:
girder_worker/girder_worker/docker/transforms/girder.py
Line 174 in 35b1830
I believe this returns a full file path, not a parent directory path.
The text was updated successfully, but these errors were encountered:
HA! I opened #327 like a year ago then forgot about it.
Looks like this is still an issue. Not sure why that issue was closed.
Reproduce with Dockerfile:
FROM debian:buster-slim COPY entrypoint.sh / RUN chmod +x /entrypoint.sh ENTRYPOINT ["/entrypoint.sh"]
entrypoint.sh:
#!/bin/sh -e ls "$1"
if any part of the path has spaces and you use any of the girder docker transforms as input paths, you get a no such file or directory.
Sorry, something went wrong.
No branches or pull requests
I don't think it's docker-py's burden to do anything other than
' '.join(container_args)
If our transforms return strings that might have spaces, they also need to be quoted.
Also random note:
girder_worker/girder_worker/docker/transforms/girder.py
Line 174 in 35b1830
I believe this returns a full file path, not a parent directory path.
The text was updated successfully, but these errors were encountered: