Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addImage not working with parameter in URL #433

Closed
katsuya-horiuchi opened this issue Nov 17, 2018 · 1 comment
Closed

addImage not working with parameter in URL #433

katsuya-horiuchi opened this issue Nov 17, 2018 · 1 comment
Assignees
Milestone

Comments

@katsuya-horiuchi
Copy link
Contributor

If URL contains parameter, passing path to addImage function leads to data corruption of file.

Example:

var pptx = new PptxGenJS();
var slide pptx.addNewSlide();
slide.addImage({
  path: "https://gitbrent.github.io/PptxGenJS/img/feature-callout.png?key=value",
  x: 1,
  y: 1
})
pptx.save("test");

Would it be possible to include images whose URL path has parameter?

katsuya-horiuchi pushed a commit to katsuya-horiuchi/PptxGenJS that referenced this issue Nov 20, 2018
gitbrent added a commit that referenced this issue Nov 26, 2018
Remove query and fragment from image's extension (Issue #433)
@gitbrent gitbrent self-assigned this Nov 26, 2018
@gitbrent gitbrent added this to the 2.5.0 milestone Nov 26, 2018
@gitbrent
Copy link
Owner

Pull request merged into master branch.

Thanks @katsuya-horiuchi !

gitbrent added a commit that referenced this issue Nov 26, 2018
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Remove query and fragment from image's extension (Issue gitbrent#433)
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants