Grants "Total Funded" count is incorrect

[markusbkoch]

Describe the bug
The amount displayed in the "Total Funded" field of a grant page doesn't match the amount that was donated.

To Reproduce
See https://gitcoin.co/grants/233/ethereumetl?tab=activity
As of now, it shows total funded is 105 DAI, but that amount takes into account a 25 DAI donation by user rraina. However, that donation never went through. The approve transaction went through, but the transfer failed because the account didn't have enough DAI in it.

Expected behavior
I would expect the total funded value to match the sum of the values transferred, not the sums of the values approved.
I would expect the links to Etherscan next to each contribution to point to the transfer, not the approve transaction.

Screenshots

Desktop (please complete the following information):

• OS: Mac OS 10.14.6
• Browser: Google Chrome
• Browser Version: 79.0.3945.88

Additional context
Not sure how this might be affecting the CLR match computation. All contributions were in DAI, so this doesn't seem to be related to #4362

[owocki]

internal comment -- suggested fix: we should index the activity tab on whether the transferFrom() was successful, not just the approve()

[markusbkoch]

Seems the same thing is affecting the leaderboard too?
https://gitcoin.co/timdaub
Approve 1.337e+22 SAI
Failed transfer

[owocki]

i put in a fix for the leaderboard :)

heres a root cause fix spec i typed up ... let me konw if u think it looks ok #5762