This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Unzipped resources cannot be directly moved between drives #836
Assignees
Labels
Comments
|
Hey @tkaczz thanks for filling out the issue. You mentioned something about a drive partition, could you elaborate? |
|
I have ram disk (1GB) set up as cache for other apps, but I checked that plugin again with turned off ram cache, but issue still remains. I modified TMP/TEMP env var which points to that ram drive. If that matters I have Unity 2017.4.5f1 and Windows 7 64bit. |
|
@tkaczz Are there any files in |
|
Yes Tried to create empty project (not git repo) with imported GitHub for Unity. After switching to GitHub window there is still same issue. I can see in behind that there is option to initialize git repo, but it's grayed out and I can't click it. In settings tab, I saw that this addon correctly discovered my system git+lfs install, used default settings for rest. Log 2nd scenario Log Log after Unity editor restart My issue is same as this one |
|
I have pretty much the same issue, but the GitHub editor panel shows "Initialization failed". I have a feeling that this is related to the location of the opened project and perhaps the Unity Editor, since the path |
|
Hey @macklinb thanks for filing the issue. |
|
Hi @StanleyGoldman. Here's the same log, but with trace logging enabled. Comparing the files in octorun_extract_archive_path_1183125159 and octorun.zip, it looks like everything extracted properly. I assume it's just the move that is failing. |
|
I had the same issue with the rotating logo never disappearing and under the Settings tab it would not find the git installation. Here's how I fixed it: I checked my .gitconfig file which for me (windows 10) was at C:\Users\whateverYourUsernameIs (that's %HOME%) and there the wrong name was set. It was like this: The error being that my Github username is not actually Philipp. So I changed name to my Github username and email to my email I use for Github. Then when I opened the Unity project again a "Initilising" bar appeared under the forever-rotating Logo and voila a minute later it magically started working. |
|
Hey @tkaczz and @macklinb sorry it's taken so long to get to this. I've been working on a few other projects. I'd like to get this one figured out but I may need to send you guys a few test builds in order to figure it out. This is related to #898 @AllBecomesGood thanks for helping, but I think their issue is a bit different. |
|
Can you check out the built package from #925? So we perform a delete operation right before the move after we unzip. I think the delete is still occurring when we attempt the move, which is what leaves us in this state. This build will give me a bit more logging into what I think is happening. So if you can test it out, repro the issue, and upload me a new log file, we can try to get this bug nabbed. |
|
Hi @StanleyGoldman, the package you provided doesn't seem to want to open in either 2018.1.1f1 or in the latest 2018.2.11f1, could you unpackage the file and reupload the files in a zip instead? |
|
hmm, let me test that for myself... |
|
Doh... We just had that build system working, I thought everything would be fine... |
|
Okay, I created the file locally... so much for automation. 🤷♂️ github-for-unity-1.1.0.4986-ae4f4f65.unitypackage.zip Please unzip and try this. (I tested it first this time.) |
|
That was quick, thanks! I'll give it a go. |
|
I'm on discord right now, if you have time. We can try to make the feedback loop faster. |
|
Tested it with trace logging enabled. Same issue :( Sorry, it'll have to be another time - I'm in Australia and it's 2:45am at the moment =P |
|
I expected the error, I am just looking to get more information about what is wrong. |
|
Lets try this one.. |
|
That seemed to get things going. No more spinny logo, and I can now log in. Did you find out what the problem was? Edit: I should note that I deleted the GitHubUnity folder before importing the plugin. |
|
Okay I tested the latest build before my post github-for-unity-1.1.0.4987-dba56321 and here are results. I did it on new system install because my ssd drive failed :( Tested two scenarios in Unity 2017.4.f11 and 2018.3.b3. After each one I deleted %appadata%/Local/GitHubUnity folder.
Second one
Unity 2017.4.f11 Second one Unity 2018.3.b3 Second one I observed weird behaviour with Unity 2017.4.f11. I tested it again, previously set by me settings were saved even between tests. It seems like it's working, no errors, can create repo etc. It looks like it has problems with creating, detecting initial settings. git config --global --list is printing correct settings in both bash for windows and powershell. |
|
@macklinb Awesome. I think I needed to change the copy method because your temp folder and user folder are on different drives. Before I tried to move the folder directly from @tkaczz Awesome. That change also got you over the first hump. So a few things...
Also, it seems like the error the first time (in 2018.4 I believe) was due to internet connectivity. So let's try to delete both folders and give it a fresh install. |
|
@macklinb can you do me another favor? I just wanna be absolutely sure we fixed the issue, and that we didn't just get lucky... |
|
Sure thing. I downloaded 1.0.3 from the releases page, deleted GitHubUnity from So I guess it's not a coincidence. Also, I understand that my Temp folder being on a different drive to my user folder is a bit of an edge case. Hopefully others that have similar setups won't have this problem anymore =) |
|
That's fine, I've seen this error since our early days and we never figured it out. Thanks for helping. |
|
Okay tested again as you suggested, here's results. System environment
Unity 2017.4.f11 Second scenario Unity 2018.3.b3 Second scenario |
|
Okay cool, so we are copying git in the same way that we were copying that other tool. So I have to make the same changes, hang on for a new build. |
|
For me curious is that in 2017 it's not working but it is in 2018. Maybe this is related to default .Net version used by them, that is .NET 2 (Unity 2017) vs .NET4.6 (Unity 2018.x)
This error is being shown in Unity 2018.3.b3 |
|
Yea, they shipped a version of sharpziplib that is actually a downgrade... |
|
Hey @tkaczz I got a new build for you to try. Clear out your folders and upload a log for me when it's done. |
|
Okay tested with 1.1.0.4988 Nothing changed in behaviour, but there are different logs Unity 2017.4.f11 Second scenario Unity 2018.3.b3 Second scenario |
|
Okay, we did get past the next roadblock, and we hit the next one, which wasn't entirely unexpected. |
|
Okay but maybe tomorrow |
|
No problem. I appreciate the help. |
|
Okay, here's results Unity 2017.4.f11 Second scenario Unity 2018.3.b3 Second scenario |
|
Hey @tkaczz thanks for your extensive testing 🏆. I believe the issue I set out to fix here has been resolved.
|
StanleyGoldman
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
After importing package to existed git+lfs (or not) repository with Unity project, and trying to use it, rotating GitHub logo is not disappearing from main view. I think that maybe my ram disk set as T partition can be issue here.
Log
Steps to Reproduce
Expected behavior:
Rotating GitHub logo disappears if Unity project is detected as git repository. This is even more weird, because it looks like this happen now.
Actual behavior:
Rotating GitHub logo is covering GitHub window view.
Reproduces how often:
Always
Additional information
I didn't set up GitHub credentials because I'm not using it.
I installed git+lfs using chocolatey. ConEmu detects git-cli so env var's are probably set up correctly.
The text was updated successfully, but these errors were encountered: