Notice: Lightshow is temporarily offline

[lildude]

We don't really have a better place for notifications, so I'm opening an issue.

Lightshow has been temporarily pulled offline whilst we address a few critical problems with it. We'll bring it back up as soon as we can.

I'll close this issue once it's back online.

Sorry for the inconvenience.

[pchaigno]

@lildude Any news on this? We can't really test any syntax highlighting change without Lightshow...

[lildude]

Nope. 😞 Still ironing out the issues.

[kivikakk]

Hiya! I've been working on getting Lightshow up and running with our new backend; it should be usable right now! Would you like to give it a test and tell me how you find it?

https://github-lightshow.herokuapp.com/

[kivikakk]

(We might like to ping the issues in the Awaiting Lightshow tag, but I think @pchaigno is mostly on top of them all!)

[pchaigno]

Thanks @kivikakk for working on this!!

I get an HTTP 503 though when I try to use it with grammar https://github.com/github-linguist/babel-sublime/blob/master/JavaScript%20(Babel).tmLanguage and example https://github.com/github/linguist/blob/master/samples/JSX/sample.jsx :-/

[kivikakk]

Something weeeeird happened with its HTTPS certificates. I've restarted the app and that particular problem seems to have cleared up, but now I'm getting timeouts on actually doing the work. Maybe because it's …/blob/… and not …/raw/….

[pchaigno]

Nop, looks like a timeout with ../raw/.. too. I'll try another grammar.

[kivikakk]

Yep, just tried. It's hitting the 10s processing timeout on the actual highlighting service. I could extend that, but I'd be wary of going too far.

[pchaigno]

Same issue with grammar https://raw.githubusercontent.com/FStarLang/atom-fstar/master/grammars/fstar.cson and example https://raw.githubusercontent.com/github/linguist/e4fd0f8cdc7c80d3c36eda3cf4dedfd482846084/samples/F*/Hacl.HKDF.fst. Was the timeout higher before?

[kivikakk]

Actually, weird: it's Lightshow's own configured timeout that is being hit here. Your latest example is trivial and not working. Looking into it. Thanks so much for your patience 🙏

[kivikakk]

Okay, turns out the lovely new service I've put into production has died hard on a malformed grammar, and hasn't restored itself 😅 It's a trivial fix/oversight of mine, so I'll let you know when I've fixed it and tested that the above samples you've demonstrated actually work.

[Alhadis]

What grammar was it, out of interest?

[kivikakk]

No idea, haven't looked that deeply into it yet. Still testing the hopeful-fix locally.

[kivikakk]

Oh, it was indeed https://github.com/github-linguist/babel-sublime/raw/master/JavaScript%20(Babel).tmLanguage! A bool which isn't playing ball (playing bool?):

<key>applyEndPatternLast</key>
<integer>1</integer>

It looks like the newer compiler is expecting an actual bool here, i.e. <true/> or <false/> instead of an integer. We're quite a lot stricter now, but I suspect this is something we should handle. I'll try making the adjustment.

[Alhadis]

playing bool?

Aahaaaaa, I get it.

[kivikakk]

Yay! Working locally. I'll deploy now.

[Alhadis]

Yay!

God I hate that indentation.

[kivikakk]

It's online and 'working' again, but for a reason I cannot fathom it's highlighting very poorly compared to my local deploy of the same (!) code.

This weirdness aside (I'll need to look into it), it should be ready for testing against again.

[worldbeater]

Trying to test this F# source file highlighting using this F# grammar, but Lightshow says something went wrong :(

[kivikakk]

It's getting very newly hammered by spammers/metasploit-type stuff, and it's not happy. Looking into it again today though 👍

[kivikakk]

Finally back online. There's an intermittent issue with SSL causing page load fails which I'm hoping has gone away with a change, but may not have; please report if you see any further difficulties.

[pchaigno]

Thanks @kivikakk!

Would it be possible to make the inputs of Lightshow (grammar link and source code) GET parameters whenever possible (i.e., unless there's a large snippet of code posted and it exceeds the URL limit)? We had this before and it's very useful to show working and broken examples to reviewers.

[kivikakk]

@pchaigno Yep, can do. I'd changed it during testing since mine were all failing due to URL limit issues, but I'll change it to be conditional on size as you've suggested.

[kivikakk]

@pchaigno Fixed! The method is a little on the conservative side; let me know if you think it's too conservative. It'd just be super annoying if legitimate input outright failed because it picked GET incorrectly.

[kivikakk]

Right now the results are a bit non-deterministic (!) — sometimes the result looks correct, sometimes it looks half-errored-out like the above screenshot of the source.js.jsx render. I'm on this today.

[kivikakk]

Determinism has returned to Lightshow!

This is the last issue I'm aware of, so if you see any more, please, let me know!

[davidhq]

Hi !

Is Lightshow gone?

[lildude]

@davidhq yes. See #5844

Unfortunately, we've had to abruptly bring the sunset date forward due to https://github.blog/2022-04-15-security-alert-stolen-oauth-user-tokens/

[davidhq]

@lildude thank you for explaining... does this mean the tool is gone forever?

[lildude]

@davidhq yes. There are more details in the issue.