Merge pull request #2590 from github/henrymercer/fix-empty-header

Do not pass undefined authorization header
github · Nov 12, 2024 · 02167d7 · 02167d7
2 parents 4dc1519 + 682c2f7
commit 02167d7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the
 
 ## [UNRELEASED]
 
-No user facing changes.
+- Fixed an issue where setting up the CodeQL tools would sometimes fail with the message "Invalid value 'undefined' for header 'authorization'". [#2590](https://github.com/github/codeql-action/pull/2590)
 
 ## 3.27.1 - 08 Nov 2024
 

diff --git a/lib/tools-download.js b/lib/tools-download.js
diff --git a/lib/tools-download.js.map b/lib/tools-download.js.map
diff --git a/src/tools-download.ts b/src/tools-download.ts
@@ -178,7 +178,8 @@ async function downloadAndExtractZstdWithStreaming(
   logger: Logger,
 ): Promise<string> {
   headers = Object.assign(
-    { "User-Agent": "CodeQL Action", authorization },
+    { "User-Agent": "CodeQL Action" },
+    authorization ? { authorization } : {},
     headers,
   );
   const response = await new Promise<IncomingMessage>((resolve) =>