Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change = New Major version #1708

Closed
b4st1en opened this issue May 26, 2023 · 5 comments
Closed

Breaking Change = New Major version #1708

b4st1en opened this issue May 26, 2023 · 5 comments

Comments

@b4st1en
Copy link

b4st1en commented May 26, 2023

Hello,

As long as you have updated the SARIF format file, the following do not work anymore using other solutions.

Some GitHub actions rely on:

  • github/codeql-action/upload-sarif@v2

And everything was fine until the v2.3.4

If there is breaking change, from my understanding, it must not keep the same Major version !

sysdiglabs/scan-action#30

@jketema
Copy link

jketema commented May 26, 2023

Hi. Thanks for your report. I'm not sure if you saw #1703, but does that cover your breakage too, or do you suspect things broke for other reasons in your case? Please also see the perviously mentioned issue as to why this was not a major version bump.

@b4st1en
Copy link
Author

b4st1en commented May 26, 2023

Thanks for your message, I'm still trying to work out why it doesn't work any more... at first I thought it was because of an update to the version of the SARIF format.
But unfortunately not, because Sysdig Secure already uses the latest SARIF format in their GitHuab action...

@jketema
Copy link

jketema commented May 26, 2023

Thanks for the update. Please let us know once you find the root cause or have any questions.

@b4st1en
Copy link
Author

b4st1en commented May 26, 2023

Ok, the root cause was a some "Problem Exists Between Chair And Keyboard" because dev teams sound the alarm too fast... or maybe too late... or both...

It appears that the v2.3.5 already solved the issue !

Sorry for disturbance :'(

@jketema
Copy link

jketema commented May 26, 2023

No worries and great that you've been able to track the problem down. I'm closing this issue now, as things seem to be resolved.

@jketema jketema closed this as completed May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants