Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload-serif@v1: Unable to override commit_sha #890

Closed
benmoss opened this issue Jan 27, 2022 · 3 comments
Closed

upload-serif@v1: Unable to override commit_sha #890

benmoss opened this issue Jan 27, 2022 · 3 comments

Comments

@benmoss
Copy link

benmoss commented Jan 27, 2022

I am trying to have a periodic action that checks for vulnerabilities in the latest release of my repo. The schedule event sets GITHUB_SHA and GITHUB_REF to the latest commit of the default branch, which is not what I want.

I've tried setting these env vars on the step but it seems to have no effect, it still ends up uploading as the latest commit on my default branch. Maybe GitHub doesn't allow these to be overridden. I tried doing a checkout of that tag in a prior step as well and it also had no effect.

If these action just had a commit_sha/ref input that'd be a simple enough workaround.

@aeisenberg
Copy link
Contributor

Possibly related to #889.

@benmoss
Copy link
Author

benmoss commented Jan 27, 2022

Possibly related to #889.

Nice, I think that exactly fixes my issue if I'm reading it correctly

@aeisenberg
Copy link
Contributor

The fix for this has been merged. Please comment here if you still have the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants