Use apiURL to determine whether to use the token #1615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codeqlURL in this check will refer to the API url to use to download the release. For example: https://api.github.com/repos/myrepo/codeql-action/releases/assets/<id> However, the apiDetails.url refers to the instance URL, e.g. https://github.com. We therefore need to use the apiDetails.apiURL to get the appropriate comparison.
henrymercer
reviewed
Mar 28, 2023
| @@ -608,7 +608,7 @@ export async function downloadCodeQL( | |||
| let authorization: string | undefined = undefined; | |||
| if (searchParams.has("token")) { | |||
| logger.debug("CodeQL tools URL contains an authorization token."); | |||
| } else if (codeqlURL.startsWith(`${apiDetails.url}/`)) { | |||
| } else if (codeqlURL.startsWith(`${apiDetails.apiURL}/`)) { | |||
There was a problem hiding this comment.
If a user provides a tools URL explicitly like tools: https://github.com/github/codeql-action/releases/download/codeql-bundle-20230317/codeql-bundle-linux64.tar.gz, I think we'll want to authenticate this too. Therefore I think we might want to loosen this to codeqlURL.startsWith(`${apiDetails.url}/`) || codeqlURL.startsWith(`${apiDetails.apiURL}/`).
3 tasks
|
Closing in favor of #1945. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action includes this check to determine whether to include the token in the request:
The intention is to only include the token if we are fetching from the same instance, to avoid leaking tokens.
However, the
codeqlURLin this check will refer to the APIurlto use to download the release. For example:https://api.github.com/repos/myrepo/codeql-action/releases/assets/
However, the
apiDetails.urlrefers to the instance URL, e.g.https://github.com, which means the check will always fail. We therefore need to use theapiDetails.apiURLto get the appropriate comparison.Merge / deployment checklist